feat: Make datastore async/await. #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: throw error instead of calling process.exit in try/catch. Let the process fail on it's own. fix: Shell adapter wasn't closing the Readline stream properly. It was causing test scenarios to hang. fix: adapter.emote had a typo fix: call removeAllListeners in close method. fix: Response.play() wasn't working. fix: argument being sent to the catchAll callback was not correct. It's supposed to be a CatchAllMessage type. chore: Add @deprecated for Brain wrapper methods in Adapter chore: Remove is-circular chore: Replace mocha with Node's Test Runner chore: Remove chai, sinon and sinon-chai BREAKING CHANGE: Updating datastore to async/await API.
BREAKING CHANGE: Making robot.run async/await is an API change.
…osing happening close together
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: throw error instead of calling process.exit in try/catch. Let the process fail on it's own.
fix: Shell adapter wasn't closing the Readline stream properly. It was causing test scenarios to hang.
fix: adapter.emote had a typo
fix: call removeAllListeners in close method.
fix: Response.play() wasn't working.
fix: argument being sent to the catchAll callback was not correct. It's supposed to be a CatchAllMessage type.
chore: Add @deprecated for Brain wrapper methods in Adapter
chore: Remove is-circular
chore: Replace mocha with Node's Test Runner
chore: Remove chai, sinon and sinon-chai
BREAKING CHANGE: Updating datastore to async/await API.