Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make datastore async/await. #1666

Merged
merged 9 commits into from
Sep 23, 2023
Merged

feat: Make datastore async/await. #1666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
04bdc34
feat: Make datastore async/await.
joeyguerra Sep 17, 2023
a5dfd99
BREAKING CHANGE: Bump Node support to v18
joeyguerra Sep 17, 2023
7697dca
Get tests working with node v18.17.1
joeyguerra Sep 18, 2023
1eacd99
It's fine if there's not history file for the shell adapter
joeyguerra Sep 18, 2023
fb8507a
fixe this[#rl].close is not a function in pipeline
joeyguerra Sep 18, 2023
79f047c
Failing on linux node v18.17.1. Try using the loop back ip instead
joeyguerra Sep 18, 2023
fc6cbba
remove unnecessary comments
joeyguerra Sep 18, 2023
808d708
feat: async/await robot.run
joeyguerra Sep 23, 2023
d7b8974
Possible race condition between loading the readline interface and cl…
joeyguerra Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs-ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
node-version: [16.x, 18.x, latest]
node-version: [18.x, latest]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion bin/hubot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,5 +153,5 @@ function loadExternalScripts () {

robot.adapter.once('connected', loadScripts)

robot.run()
await robot.run()
})()
Loading
Loading