Enable testing on macOS #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binary files were taken from homebrew bottle, version 4.3
hucsmn
reviewed
Aug 10, 2022
| fn get_binary_in<P: AsRef<Path>>(dir: P, name: &str) -> io::Result<path::PathBuf> { | ||
| use std::os::unix::fs::PermissionsExt; | ||
| let bin = dir.as_ref().join(name); | ||
| fs::set_permissions(bin.as_path(), fs::Permissions::from_mode(0o755))?; | ||
| Ok(bin) | ||
| } | ||
|
|
||
| #[cfg(all(unix, target_os = "macos"))] |
There was a problem hiding this comment.
I have noticed that the shipped bsdiff/bspatch were dynamically linked aarch64 executables.
Maybe a target_arch = "aarch64" condition should be added here, to indicate that the legacy x86_64 support for Mac is missing at now.
There was a problem hiding this comment.
May have been my omission, I thought they were universal binaries. I'll look into this to rectify the situation.
There was a problem hiding this comment.
Github actions for running test has been added on the master branch, where os: macos-latest is temporarily removed because github actions seems to be lack of arm64 containers support. It might be helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binary files were taken from homebrew bottle,
version 4.3