feat: add ability to set evm version #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obatirou
reviewed
Jul 10, 2023
| HuffConfig config = HuffDeployer.config().with_evm_version("paris"); | ||
| address withParis = config.deploy("test/contracts/EVMVersionCheck"); | ||
|
|
||
| bytes memory parisBytecode = getBytecode(withParis); |
There was a problem hiding this comment.
You could use directly withParis.code and delete getBytecode function if I am not mistaken.
obatirou
reviewed
Jul 10, 2023
| /// @dev test that compilation is different with new evm versions | ||
| function testSettingEVMVersion() public { | ||
| /// expected bytecode for EVM version "paris" | ||
| bytes memory expectedParis = hex"60028060093d393df36000"; |
There was a problem hiding this comment.
Wouldn't this should be the following for EVMVersionCheck ?
The test check the bytecode at the deployed address
bytes memory expectedParis = hex"6000";
...
bytes memory expectedShanghai = hex"5f";
...
bytes memory defaultBytecode = hex"5f";
|
It seems there are 2 distincts problems in tests:
For the second, point I did not found yet how to resolve this Update: here is a branch with all tests fixed (in local) |
|
dropped in favour of obas pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow developers to pick which evm version they deploy to.
depends on: huff-language/huff-rs#281