Fix Active Prank Issue Causing Deploy Crash During Broadcast #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug within the existing implementation of the
deploy
function inHuffConfig.sol.
Specifically, if a user intends to broadcast the deployment of the huff contract to a network, the ongoing active prank in thecreation_code_with_args
function disrupts the transaction flow, leading to a transaction failure. Consequently, this renders the deployment of huff contracts across any network utilising this framework unfeasible. The resultant console output below underscores this situation:To address this predicament, I've incorporated the vm.stopPrank() invocation just prior to the commencement of the broadcast. This strategic inclusion effectively resolves the bug: