This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Fix huffconfig address #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
previously approved these changes
Dec 3, 2022
There was a problem hiding this comment.
LGTM
Otherwise, you could use set_broadcast, which would put msg.sender as owner.
|
this should prob be merged, but we need to figure out if we are still using the asked this question in the https://discord.com/channels/980519274600882306/981015573104304209/1069326110732603452 |
This was referenced Jan 29, 2023
Merged
Merged
|
merging to |
devtooligan
dismissed stale reviews from MathisGD and themself
The base branch was changed.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ownable tests were not passing locally because the huffConfig address wasn't the correct one.
This is because this function:
https://github.com/huff-language/foundry-huff/blob/eb9ea316389e8bd580f92908b8454399401d0316/src/HuffDeployer.sol#L10-L12
returns a new HuffConfig each it's called. For a long-term fix I would propose to apply the library to a config contract instead of creating one each time a function from the lib is called.
Here is a similar issue: huff-language/foundry-huff#24