-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the megatron plugin #2822
Optimize the megatron plugin #2822
Conversation
Hey @zhangsheng377, let me give it a look now. FYI Sourab is no longer a part of HF, so I will be taking up Megatron/DS/FSDP |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
It's really unfortunate to hear about Sourab's departure. I will try to modify the code format shortly. Thank you for letting me know. |
@muellerzr Is there anything else that needs to be done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks we can go ahead and merge this. Why do you want permissions to be a committer out of curiosity?
Thank you. Because I have a strong interest in open source, I think the Accelerate project is very promising. |
For security reasons, you can only be at most a contributor, and we need to manually approve running the CI. However you have contributed to this project and it will show up in github as such :) |
Optimize the megatron plugin, and make the megatron's version to r0.5.0.
#2501 (comment)
#2390 (comment)