Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak defaults for quantized-typed FP8 TE weights #3018

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Per the NVIDIA team, we should be using HYBRID for training, E4M3 during inference. As a result, tweaks the default to be HYBRID

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, apart from the line length, LGTM.

Do the benchmarks and low_precision_training.md also need to be adjusted?

@muellerzr
Copy link
Collaborator Author

Benchmarks actually used HYBRID from the start (since I was looking at nvidia's examples directly) so those are fine :)

@muellerzr muellerzr merged commit 7ec8eab into main Aug 19, 2024
28 checks passed
@muellerzr muellerzr deleted the tweak-fp8-defaults branch August 19, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants