Improve config handling and add a zoo #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
approved these changes
Aug 20, 2024
src/accelerate/utils/dataclasses.py
Outdated
Comment on lines
1340
to
1344
| sync_module_states: bool = field( | ||
| default=False, | ||
| default=None, | ||
| metadata={ | ||
| "help": "Whether each individually wrapped FSDP unit should broadcast module parameters from rank 0 " | ||
| "to ensure they are the same across all ranks after initialization. Defaults to `True`" |
There was a problem hiding this comment.
In the post_init, I can see that actually the default is False. Either change the description or the init below. Also thanks for fixing this !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a config zoo to the repo, showcasing a number of "template" config files users can use.
This PR also tweaks how the config yamls are read, so we can simplify certain configurations better, relying on inferred (but valid) parameters, which our CLI already does.
E.g. this is a full, complete, valid config yaml for single-gpu bf16 training:
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc