add set_epoch for MpDeviceLoaderWrapper #3053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
in transformers' trainer.py, when using xla resume, the data_iterator used during resumption is different from the original data_iterator. It is necessary to use set_epoch with the current epoch value: https://github.com/huggingface/transformers/blob/3bf6dd8aa141ff6bebd579649e9d0ba8bf5d03db/src/transformers/trainer.py#L2264. However accelerator adds an additional wrapper for xla: MpDeviceLoaderWrapper, which does not have a set_epoch method, this leads to incorrect epoch value and data being used in subsequent training (the random seed in the data loader's sampler is related to the epoch value). To resolve this issue, we add a set_epoch method to MpDeviceLoaderWrapper.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.