Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable setting state dict type #3084

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

0.34.0 removed the ability to set the state_dict_type on the fly, which I had assumed was fine, however I wasn't aware that users typically will:

  • Use SHARDED_STATE_DICT for checkpoints
  • Use FULL_STATE_DICT for the final model

As a result, brings it back and documents the desired behavior

Fixes #3072

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Thanks !

@muellerzr muellerzr merged commit 9d67867 into main Sep 5, 2024
28 checks passed
@muellerzr muellerzr deleted the muellerzr-last-fsdp-fix branch September 5, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting FSDP FULL_STATE_DICT explicitly doesn't work
3 participants