fix loading sharded checkpoints from subfolder #8798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
currently we are not able to load shared checkpoints from a subfolder, e.g. cannot load lavender #8796 (comment) I just added a commit to make it work, feel free to take this over and make it better @sayakpaul |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
Jul 6, 2024
| @@ -221,7 +221,7 @@ def _fetch_index_file( | |||
| local_files_only=local_files_only, | |||
| token=token, | |||
| revision=revision, | |||
| subfolder=subfolder, | |||
| subfolder=None, | |||
There was a problem hiding this comment.
Why should this be None, though?
There was a problem hiding this comment.
That is because subfolder is already determined here:
|
@yiyixuxu thanks! I added two commits:
I think the PR should be good to merge after you review it. |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* fix load sharded checkpoints from subfolder{
* style
* os.path.join
* add a small test
---------
Co-authored-by: sayakpaul <spsayakpaul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for this #8796