-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small modification to enable usage by external scripts #956
Conversation
Add parameter inputs to training and argument parsing function to allow this script to be used by an external call.
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine for me - @patil-suraj what do you think?
@@ -312,8 +316,7 @@ def get_full_repo_name(model_id: str, organization: Optional[str] = None, token: | |||
return f"{organization}/{model_id}" | |||
|
|||
|
|||
def main(): | |||
args = parse_args() | |||
def train(args): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say let's not change this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot for the PR! Just left one comment, let's not change the function name from main
to train
for consistency with our other scripts.
Hi,
|
This change enables dreambooth training to be called by an external script. This makes it much easier to write wrappers around training for GUI's or batch processing scripts. This change does not break existing usage.