Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug for multiple prompts inputs #959

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

xiaohu2015
Copy link
Contributor

@xiaohu2015 xiaohu2015 commented Oct 24, 2022

fig bugs for multiple prompts, for examples:

prompt = [
    "a cat sitting on a bench",
    "a dog sitting on a bench",
    "a man sitting on a bench"
]

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 24, 2022

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten
Copy link
Contributor

patrickvonplaten commented Oct 26, 2022

Thanks a lot for the PR @xiaohu2015 :-)

@patil-suraj could you review here for in-paint?

@patrickvonplaten patrickvonplaten self-assigned this Oct 26, 2022
@patrickvonplaten
Copy link
Contributor

We should also add a test for this please :-)

@xiaohu2015
Copy link
Contributor Author

We should also add a test for this please :-)

I think we don't have to add a test, since I only fix a small bug.

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thanks a lot for the fix @xiaohu2015 ! This works perfectly.

@patrickvonplaten I will add a test for this in follow-up a PR, I tried manually and works well

@patil-suraj patil-suraj merged commit bd06dd0 into huggingface:main Oct 26, 2022
@xiaohu2015 xiaohu2015 deleted the patch-2 branch October 26, 2022 14:42
@patrickvonplaten
Copy link
Contributor

Cool thanks for checking! Let's maybe also add a test here :-)

yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants