Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimum fixes #149

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Optimum fixes #149

merged 3 commits into from
Mar 21, 2022

Conversation

sgugger
Copy link
Contributor

@sgugger sgugger commented Mar 17, 2022

In a namespace module (like optimum), submodules won't directly appear as attributes. You need to import them at least one explicitly before they do. This PR does that.

@sgugger sgugger requested a review from LysandreJik March 17, 2022 16:19
@lewtun lewtun mentioned this pull request Mar 17, 2022
Merged
LysandreJik
LysandreJik approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for investigating @sgugger @lewtun!

@sgugger sgugger merged commit 6f68918 into main Mar 21, 2022
@sgugger sgugger deleted the optimum_fixes branch March 21, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgugger @LysandreJik