Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry for failed pushes #150

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Retry for failed pushes #150

merged 2 commits into from
Mar 18, 2022

Conversation

sgugger
Copy link
Contributor

@sgugger sgugger commented Mar 18, 2022

This PR changes the doc building jobs to try to rebase and push again if the first push fails.

@sgugger sgugger requested a review from LysandreJik March 18, 2022 15:11
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's give this a try!

Comment on lines 92 to 94
git push origin main ||
(echo "Failed on the first try, rebasing and pushing again" && git pull --rebase git && push origin main) ||
(echo "Failed on the second try, rebasing and pushing again" && git pull --rebase git && push origin main)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& not at the right place?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes they call me eagle eye

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, thanks a lot!

git push origin master
git push origin main ||
(echo "Failed on the first try, rebasing and pushing again" && git pull --rebase && git push origin master) ||
(echo "Failed on the second try, rebasing and pushing again" && git pull --rebase && git push origin master)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master or main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename all those masters to main already ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename transformers' master branch to main on Monday? 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooooooooooooooooooooooooooo!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgugger sgugger merged commit a1b0e76 into main Mar 18, 2022
@sgugger sgugger deleted the retry_push branch March 18, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants