Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 use proper package_name in doc-builder build cmd #309

Merged
merged 2 commits into from
Oct 6, 2022
Merged

🐛 use proper package_name in doc-builder build cmd #309

merged 2 commits into from
Oct 6, 2022

Conversation

nateraw
Copy link
Contributor

@nateraw nateraw commented Oct 5, 2022

Resolves #305

@nateraw nateraw requested a review from mishig25 October 5, 2022 16:26
@nateraw
Copy link
Contributor Author

nateraw commented Oct 5, 2022

seems to be a GitHub actions outage right now, so can't test this til that's resolved

@nateraw
Copy link
Contributor Author

nateraw commented Oct 5, 2022

Tested in timm

Still should probably check it works with other packages

@mishig25
Copy link
Contributor

mishig25 commented Oct 6, 2022

thanks a lot for working on this! testing it at: huggingface/transformers#19372

mishig25
mishig25 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! test succeeded

merge whenever you'd like to

@nateraw nateraw merged commit a8a5a55 into main Oct 6, 2022
@nateraw nateraw deleted the fix-issue-305 branch October 6, 2022 15:30
@mishig25 mishig25 mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishig25 mishig25 mishig25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build docs using package name that differs from repo name
2 participants
@nateraw @mishig25