Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape html vid tag #339

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Escape html vid tag #339

merged 1 commit into from
Dec 26, 2022

Conversation

mishig25
Copy link
Contributor

@mishig25 mishig25 commented Dec 26, 2022

<video xyz></video> was already working since doc-builder detects opening & closing tags of any html. However, when they are combined <video xyz/> was not being detected as HTML video tag. This PR solves it

@mishig25 mishig25 changed the title Escape html vid Escape html vid tag Dec 26, 2022
@mishig25 mishig25 merged commit cc2be79 into main Dec 26, 2022
@mishig25 mishig25 deleted the escape_html_vid branch December 26, 2022 11:58
@mishig25
Copy link
Contributor Author

Video in https://huggingface.co/docs/hub/spaces-more-ways-to-create is displyaed correctly now

Screenshot 2022-12-26 at 13 04 04

@julien-c
Copy link
Member

nice! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants