Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape ` inside img alt descriptions #406

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Escape ` inside img alt descriptions #406

merged 1 commit into from
Sep 25, 2023

Conversation

mishig25
Copy link
Contributor

@mishig25 mishig25 commented Sep 25, 2023

Should fix the following error locally:

Unexpected token (Note that you need plugins to import files that are not JavaScript)
file: /tmp/tmp2zqefn3k/kit/src/routes/guides/search/+page.svelte:202:169
200:   let t105;
201:   let p15;
202:   let textContent_20 = `<img src="https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/search_text_classification.gif" alt="Animation exploring `model_args...

as you can see in let textContent_20 = , svelte/mdsvex compile is using `, which is why the alt description can't have `

@mishig25 mishig25 merged commit e786f03 into main Sep 25, 2023
4 checks passed
@mishig25 mishig25 deleted the escape_img_alt branch September 25, 2023 09:16
@mishig25
Copy link
Contributor Author

@Wauplin
Copy link
Contributor

Wauplin commented Sep 25, 2023

@mishig25 Awesome! Thanks for working of it. That will finally settle this regex issue for good. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants