Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename evaluation modules #160

Merged
merged 13 commits into from
Jul 5, 2022
Merged

Rename evaluation modules #160

merged 13 commits into from
Jul 5, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jun 24, 2022 •
edited
Loading

This PR addresses comments in #150 regarding the naming of the EvaluationModule. To make things clearer the base class EvaluationModule has now three children: Metric, Comparison, and Measurement. Same for the EvaluationModuleInfo.

You can ignore the update modules commit which updates all classes for the implemented metrics. There are a few things left to do:

  • update the docs
  • update the template to create new modules
  • add proper docstrings and update existing

What do you think?

@lvwerra lvwerra requested review from sashavor and lhoestq June 24, 2022 14:50
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 24, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@lvwerra lvwerra mentioned this pull request Jun 24, 2022
Merged
@lhoestq
Copy link
Member

lhoestq commented Jun 27, 2022

Love it ! Thanks a lot @lvwerra :)

@lvwerra lvwerra marked this pull request as ready for review June 28, 2022 15:50
@lvwerra
Copy link
Member Author

lvwerra commented Jun 29, 2022

Hi @lhoestq and @sashavor, added the missing todos. Ready for another review. Thanks!

sashavor
sashavor approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this makes things so clear! thank you @lvwerra

lhoestq
lhoestq approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks ! :D

src/evaluate/module.py Outdated Show resolved Hide resolved
@lvwerra @lhoestq
Apply suggestions from code review
7c6d734 
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
@lvwerra lvwerra merged commit 3a62fc3 into main Jul 5, 2022
@lvwerra lvwerra deleted the rename-evaluation-modules branch July 5, 2022 07:55
@lvwerra lvwerra mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

@sashavor sashavor sashavor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lvwerra @HuggingFaceDocBuilderDev @lhoestq @sashavor