Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a tokenizer option to rouge #258

Merged
merged 1 commit into from
Aug 18, 2022
Merged

add a tokenizer option to rouge #258

merged 1 commit into from
Aug 18, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Aug 18, 2022

This PR adds a tokenizer option to the Rouge score, so any callable can be passed to the metric.

closes #256 #108

@lvwerra lvwerra requested a review from sashavor August 18, 2022 09:48
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 18, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@sashavor sashavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super useful! Thanks @lvwerra 👨‍🎤

@lvwerra lvwerra merged commit d5ecbe4 into main Aug 18, 2022
@lvwerra lvwerra deleted the add-rouge-tokenizer branch August 18, 2022 17:36
mathemakitten pushed a commit that referenced this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rouge not working for non-Latin scripts
4 participants