Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTML relative paths for tiles #318

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Use HTML relative paths for tiles #318

merged 1 commit into from
Oct 10, 2022

Conversation

lewtun
Copy link
Member

@lewtun lewtun commented Oct 10, 2022

This PR replaces the absolute paths in the landing page tiles with relative ones so that one can test navigation both locally in and in future PRs (see here for an example PR where the links don't work).

I encountered this while working on the optimum docs and figured I'd fix it elsewhere too :)

Internal Slack thread: https://huggingface.slack.com/archives/C02GLJ5S0E9/p1665129710176619

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 10, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🚀

@lvwerra lvwerra merged commit a785429 into main Oct 10, 2022
@lvwerra lvwerra deleted the use-relative-urls branch October 10, 2022 08:15
NimaBoscarino pushed a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants