Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for EvaluationSuite #340
Docs for EvaluationSuite #340
Changes from 8 commits
05c3b32
c409f3e
5011b28
96c3a0e
f7d014a
3bf419e
8309ad2
c232876
064539b
d5bc020
cb921fe
da413f8
7fe7a57
f0b5897
d97b7fb
fb89329
7da77ed
f52ac02
52abfd7
474fa55
8ca9b1a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to give instructions how to add a new Suite on the hub (for people who don't know how). For metrics there is a small CLI using Cookiecutter where you specify the name of the metric and it creates the spaces, clones it locally and adds template files. Similar to the metric modules we could also add
If you want I could help with that. I think reducing friction to create a new suite to the minimum will maximise adoption. Happy to do it in a follow up PR but I think it would be great to have with the release/announcement. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, sounds good, having a README and/or template seems broadly useful!
I've added some more instructions in evaluation_suite.mdx as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you list the available task types maybe ? Or redirect to their docs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a link to the supported tasks on the Evaluator docs so we don't have to maintain the list in two places!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) Would be nice to show it as a pandas DataFrame for readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, the result is now a list of dicts so it can be easily transformed into a dataframe. I've added that to the example 😄