-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python to 3.8 #571
Update python to 3.8 #571
Conversation
Now, other tests are failing
I would appreciate any thoughts @lhoestq |
Cool, thansk for updating :) Maybe we should also update setup.py to require python >= 3.8 as well. The scipy test can surely be fixed using numpy.testing.assert_almost_equal or something like that, if you want to fix it in this PR I'm a bit less sure about the filelock issue, we can leave that for later. |
Regarding scipy, adding tolerance would be not enough, because the current confidence interval in tests (0.3333, 0.6666), but after scipy update we have (0.3355, 1.0). |
Ah yes indeed. We should align with the latest scipy |
Ok, I fixed scipy version, the only failing test is for the distributed metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! I opened #578 that hopefully fixes the last test
The latest versions of datasets and transformers require Python 3.8. Currently, CI and a package have Python 3.7 as a requirement, leading to tests failing (#569). I was able to reproduce the failing tests with the same dependencies installed during the CI, probably it's worth updating the package's Python requirement to Python 3.8 too.
I have updated Python to 3.8 in CI to see if it became green.