FIX Honor HF_HUB_OFFLINE mode if set by user #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves huggingface#1452 If users enable offline mode, don't perform checks for files on HF Hub, as they would fail.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
pacman100
approved these changes
Feb 12, 2024
|
However, this won't handle the timeout scenarios like the recent one, right? |
No, I don't think so. We could try to add that by including the corresponding exception. Do you know which one that is? |
|
|
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Do we know when this will be included in a release? |
We're finishing up a last few PRs, after that we should be ready for a release. We aim for this week. |
BenjaminBossan
added a commit
to BenjaminBossan/peft
that referenced
this pull request
Mar 14, 2024
Resolves huggingface#1452 If users enable offline mode, don't perform checks for files on HF Hub, as they would fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1452
If users enable offline mode, don't perform checks for files on HF Hub, as they would fail.