FIX [CI] Fix test docker CI
#1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesbelkada
commented
Mar 5, 2024
| uses: actions/checkout@v3 | ||
| - name: Get changed files | ||
| id: changed-files | ||
| uses: tj-actions/changed-files@1c8e6069583811afb28f97afeaf8e7da80c6be5c #v42 |
There was a problem hiding this comment.
points out to the latest commit
younesbelkada
commented
Mar 5, 2024
Comment on lines
27
to
33
| env: | ||
| ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }} | ||
| run: | | ||
| for file in "$ALL_CHANGED_FILES"; do | ||
| echo "$file was changed" | ||
| done | ||
| echo "matrix=${{ steps.changed-files.outputs.all_changed_files}}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
this is the main change
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
approved these changes
Mar 5, 2024
younesbelkada
commented
Mar 5, 2024
|
I'll leave it up to an expert to judge if this is a sufficient mitigation for the linked vuln. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue we had with the test-docker-build workflow, as stated by the dependabot here we should make use of env variables to avoid issues
cc @glegendre01 @sayakpaul @pacman100 @BenjaminBossan