Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deepspeed zero3+prompt tuning bug. word_embeddings.weight shape i… #1591

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

sywangyi
Copy link
Contributor

…s torch.Size([0])

…s torch.Size([0])

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
Contributor Author

@younesbelkada please help review

@BenjaminBossan
Copy link
Member

Thanks for this PR. Just to confirm, you tested this fix with DeepSpeed and it was necessary and sufficient to allow training the model?

@sywangyi
Copy link
Contributor Author

yes. I have tested this fixed with deepspeed. and with the fix. the training could continue without error.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for identifying this issue with prompt tuning + DeepSpeed and providing the fix!

@BenjaminBossan BenjaminBossan merged commit c4c826c into huggingface:main Mar 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants