Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX / Workflow: Always notify on slack for docker image workflows #1682

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

younesbelkada
Copy link
Contributor

What does this PR do?

As per title, we were not posting on slack when the docker image build fails, this PR enables it

cc @pacman100 @BenjaminBossan

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@BenjaminBossan
Copy link
Member

@younesbelkada Could you please merge main so that the tests can pass?

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@younesbelkada younesbelkada merged commit 383e1fa into main Apr 26, 2024
14 checks passed
@younesbelkada younesbelkada deleted the younesbelkada-patch-3 branch April 26, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants