MNT Upgrade ruff version to ~0.4.8 #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use ruff v0.2.2, which is quite far behind the latest version. This has the disadvantage that new contributors will often install the latest version of ruff and then get CI errors, even though they ran `make style`. With this update, the discrepancy should go away. But if we merge this, all contributors may have to update their PRs. This is annoying but I think we need to do this sooner or later. Here is the full list of changes: - bump ruff version to ~0.4.8 - update the ruff commands in Makefile (ruff foo/ -> ruff check foo/) - update coding style of two files that changed with the new ruff version
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use ruff v0.2.2, which is quite far behind the latest version. This has the disadvantage that new contributors will often install the latest version of ruff and then get CI errors, even though they ran
make style.With this update, the discrepancy should go away. But if we merge this, all contributors may have to update their PRs. This is annoying but I think we need to do this sooner or later.
Here is the full list of changes: