-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdaLora: Trigger warning when user uses 'r' inplace of 'init_r' #1981
Conversation
@BenjaminBossan is this what you were suggesting in the comment on #1971 |
Thanks for working on this suggestion. The PR looks good (nice catch adjusting the docstring). Would you be so kind as to also add unit tests for this warning? So in Also, please ensure that the character limit of 120 chars per line is kept. |
Thank you for reviewing. I have added the test for AdaLoraConfig warning. |
Thanks, could you please run |
Sorry, previously i could not run make properly and found out my ruff (0.5.5) version was different and was getting numerous errors. I did it with ruff==0.4.10 as you suggested in one of the PRs. Thanks. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this so quickly!
Description:
This PR addresses Issue #1971 by adding a warning in
__post_init__
ofAdaLoraConfig
whenr
is set to any non-default value. The changes aim to clarify the usage ofinit_r
instead ofr
inAdaLoraConfig
, resolving confusion around parameter naming.Updated the docstring example in AdaLoraModel to reflect the same.
Testing:
Related Issues
✅ Closes #1971