Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] enable regression tests on XPU #2019

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Aug 20, 2024

Before fix:

============================================ short test summary info ============================================
FAILED tests/regression/test_regression.py::TestOpt::test_adalora - RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If y...
FAILED tests/regression/test_regression.py::TestOpt::test_ia3 - RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If y...
FAILED tests/regression/test_regression.py::TestOpt::test_lora - RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If y...

After fix:

============================================ short test summary info ============================================
PASSED tests/regression/test_regression.py::TestOpt::test_adalora
PASSED tests/regression/test_regression.py::TestOpt::test_ia3
PASSED tests/regression/test_regression.py::TestOpt::test_lora
======================================== 3 passed, 2 warnings in 18.80s =========================================

@faaany
Copy link
Contributor Author

faaany commented Aug 20, 2024

@BenjaminBossan

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for modifying the regression tests to make them work on XPU.

Just to confirm @faaany: You could verify that these failing tests pass with the proposed fix (asking since I cannot test myself)?

@faaany
Copy link
Contributor Author

faaany commented Aug 20, 2024

Thanks for modifying the regression tests to make them work on XPU.

Just to confirm @faaany: You could verify that these failing tests pass with the proposed fix (asking since I cannot test myself)?

Yes, I tested it on XPU.

@BenjaminBossan
Copy link
Member

Yes, I tested it on XPU.

Great, thanks for the good work.

@BenjaminBossan BenjaminBossan merged commit 25ab6c9 into huggingface:main Aug 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants