Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue caused by #433 blindly passing **kwargs all over the place #535

Closed
wants to merge 3 commits into from

Conversation

winglian
Copy link
Contributor

@winglian winglian commented Jun 1, 2023

#433 caused a regression breaking any code using device_map as a kwarg to PeftModel.from_pretrained, so like half the internet.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@pacman100
Copy link
Contributor

Hello, Thank you for the fixes! Please resolve the failures in order to quickly merge the fixes.

@winglian winglian changed the title Fix issue caused by #443 blindly passing **kwargs all over the place Fix issue caused by #433 blindly passing **kwargs all over the place Jun 7, 2023
@pacman100
Copy link
Contributor

Thank you for iterating, make style and make quality should resolve the code quality issues and then PR would be good to merge

@younesbelkada
Copy link
Contributor

Hi @winglian
Thank you very much for your PR, I have made #575 and added you as a co-author there, let's close this PR once #575 gets merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants