[docs, untested] Attempt to fix links to source #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Narsil too, in case you know how to test |
|
Thanks for this |
pcuenca
added a commit
to pcuenca/safetensors
that referenced
this pull request
Jan 8, 2024
Followup to huggingface#420. Sorry. We're almost there, examine the first `<source>` link in https://huggingface.co/docs/safetensors/api/torch to verify.
Narsil
pushed a commit
that referenced
this pull request
Jan 11, 2024
Followup to #420. Sorry. We're almost there, examine the first `<source>` link in https://huggingface.co/docs/safetensors/api/torch to verify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The functions in this page link to something like:
https://github.com/huggingface/safetensors/blob/main/src/safetensors/torch.py#L284 (which does not exist), however
https://github.com/huggingface/safetensors/blob/main/bindings/python/py_src/safetensors/torch.py#L284 does.
Looking at https://github.com/huggingface/doc-builder/blob/bc09a535b7ed1ccd1b57b59ccc0584a286fc3397/.github/workflows/build_main_documentation.yml#L159C38-L159C38 I see
version_tag_suffixbeing used and accepted here.I tried to test locally but
--version_tag_suffixwas not accepted, so I may still be missing something.cc @mishig25