Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with changes related to LLava-next multi card support #221

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

tthakkal
Copy link
Collaborator

@tthakkal tthakkal commented Sep 6, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@mandy-li
Copy link
Collaborator

mandy-li commented Sep 6, 2024

@tthakkal , can we add llava-next multi-card example command to README as well?

@tthakkal
Copy link
Collaborator Author

tthakkal commented Sep 6, 2024

@tthakkal , can we add llava-next multi-card example command to README as well?

@mandy-li Added

Copy link
Collaborator

@mandy-li mandy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment but it's not a blocker.

@@ -256,6 +254,8 @@ docker run -p 8080:80 \
-v $volume:/data \
-e HABANA_VISIBLE_DEVICES=all \
-e OMPI_MCA_btl_vader_single_copy_mechanism=none \
-e TEXT_GENERATION_SERVER_IGNORE_EOS_TOKEN=true \
-e PT_HPU_ENABLE_LAZY_COLLECTIVES=true \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to set PT_HPU_ENABLE_LAZY_COLLECTIVES to True for single card usage?

@regisss regisss merged commit a4f39a1 into habana-main Sep 7, 2024
@regisss regisss deleted the lava-next-readme-updates branch September 7, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants