Skip to content

Commit

Permalink
propagate to decoder and post processor
Browse files Browse the repository at this point in the history
  • Loading branch information
ArthurZucker committed Aug 6, 2024
1 parent 34b8f89 commit 1b926f3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
11 changes: 5 additions & 6 deletions bindings/python/src/tokenizer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1377,8 +1377,7 @@ impl PyTokenizer {
/// Set the :class:`~tokenizers.normalizers.Normalizer`
#[setter]
fn set_pre_tokenizer(&mut self, pretok: Option<PyRef<PyPreTokenizer>>) {
let pretok = pretok.map(|pre| pre.clone());
self.tokenizer.with_pre_tokenizer(pretok);
self.tokenizer.with_pre_tokenizer(pretok.map(|pre| pre.clone()));
}

/// The `optional` :class:`~tokenizers.processors.PostProcessor` in use by the Tokenizer
Expand All @@ -1393,8 +1392,8 @@ impl PyTokenizer {

/// Set the :class:`~tokenizers.processors.PostProcessor`
#[setter]
fn set_post_processor(&mut self, processor: PyRef<PyPostProcessor>) {
self.tokenizer.with_post_processor(processor.clone());
fn set_post_processor(&mut self, processor: Option<PyRef<PyPostProcessor>>) {
self.tokenizer.with_post_processor(processor.map(|p| p.clone()));
}

/// The `optional` :class:`~tokenizers.decoders.Decoder` in use by the Tokenizer
Expand All @@ -1409,8 +1408,8 @@ impl PyTokenizer {

/// Set the :class:`~tokenizers.decoders.Decoder`
#[setter]
fn set_decoder(&mut self, decoder: PyRef<PyDecoder>) {
self.tokenizer.with_decoder(decoder.clone());
fn set_decoder(&mut self, decoder: Option<PyRef<PyDecoder>>) {
self.tokenizer.with_decoder(decoder.map(|d| d.clone()));
}
}

Expand Down
8 changes: 4 additions & 4 deletions tokenizers/src/tokenizer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -571,8 +571,8 @@ where
}

/// Set the post processor
pub fn with_post_processor(&mut self, post_processor: impl Into<PP>) -> &mut Self {
self.post_processor = Some(post_processor.into());
pub fn with_post_processor(&mut self, post_processor: Option<impl Into<PP>>) -> &mut Self {
self.post_processor = post_processor.map(|post_proc| post_proc.into());
self
}

Expand All @@ -582,8 +582,8 @@ where
}

/// Set the decoder
pub fn with_decoder(&mut self, decoder: impl Into<D>) -> &mut Self {
self.decoder = Some(decoder.into());
pub fn with_decoder(&mut self, decoder: Option<impl Into<D>>) -> &mut Self {
self.decoder = decoder.map(|dec|dec.into());
self
}

Expand Down

0 comments on commit 1b926f3

Please sign in to comment.