[TokenizerFast] can_save_slow_tokenizer as a property for when vocab_file's folder was removed
#25626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
changed the title
TokenizerFast] Warn when vocab_file folder was removedTokenizerFast] can_save_slow as a property for when vocab_file's folder was removed
ArthurZucker
changed the title
TokenizerFast] can_save_slow as a property for when vocab_file's folder was removedTokenizerFast] can_save_slow_tokenizer as a property for when vocab_file's folder was removed
amyeroberts
approved these changes
Aug 30, 2023
| @@ -189,6 +189,10 @@ def __init__( | |||
| for k in self.fairseq_tokens_to_ids.keys(): | |||
| self.unique_no_split_tokens.append(k) | |||
|
|
|||
| @property | |||
| def can_save_slow_tokenizer(self) -> bool: | |||
There was a problem hiding this comment.
Do we know why the tokenizer didn't have this as an attribute before?
There was a problem hiding this comment.
Haha good question, I think it's because it was not really detected. In this special case the folder containing the sentencepiece model was deleted, which if it is in the cache of transformers then never / rarely happens
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
…ocab_file`'s folder was removed (huggingface#25626) * pad token should be None by default * fix tests * nits * check if isfile vocabfile * add warning if sp model folder was deleted * save SPM when missing folder for sloz * update the ` can_save_slow_tokenizer` to be a property * first batch * second batch * missing one
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
…ocab_file`'s folder was removed (huggingface#25626) * pad token should be None by default * fix tests * nits * check if isfile vocabfile * add warning if sp model folder was deleted * save SPM when missing folder for sloz * update the ` can_save_slow_tokenizer` to be a property * first batch * second batch * missing one
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
…ocab_file`'s folder was removed (huggingface#25626) * pad token should be None by default * fix tests * nits * check if isfile vocabfile * add warning if sp model folder was deleted * save SPM when missing folder for sloz * update the ` can_save_slow_tokenizer` to be a property * first batch * second batch * missing one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #25602, making
can_save_slowa property rather than an attribute as we need to check if the vocab_file still exists!