Add type hints for several pytorch models (batch-4) #25749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nablabits
changed the title
nablabits
changed the title
Rocketknight1
approved these changes
Aug 25, 2023
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
…s-for-models-batch-4
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* Add type hints for MGP STR model * Add missing type hints for plbart model * Add type hints for Pix2struct model * Add missing type hints to Rag model and tweak the docstring * Add missing type hints to Sam model * Add missing type hints to Swin2sr model * Fix a type hint for Pix2StructTextModel Co-authored-by: Matt <Rocketknight1@users.noreply.github.com> * Fix typo on Rag model docstring Co-authored-by: Matt <Rocketknight1@users.noreply.github.com> * Fix linter --------- Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* Add type hints for MGP STR model * Add missing type hints for plbart model * Add type hints for Pix2struct model * Add missing type hints to Rag model and tweak the docstring * Add missing type hints to Sam model * Add missing type hints to Swin2sr model * Fix a type hint for Pix2StructTextModel Co-authored-by: Matt <Rocketknight1@users.noreply.github.com> * Fix typo on Rag model docstring Co-authored-by: Matt <Rocketknight1@users.noreply.github.com> * Fix linter --------- Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* Add type hints for MGP STR model * Add missing type hints for plbart model * Add type hints for Pix2struct model * Add missing type hints to Rag model and tweak the docstring * Add missing type hints to Sam model * Add missing type hints to Swin2sr model * Fix a type hint for Pix2StructTextModel Co-authored-by: Matt <Rocketknight1@users.noreply.github.com> * Fix typo on Rag model docstring Co-authored-by: Matt <Rocketknight1@users.noreply.github.com> * Fix linter --------- Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses some of the models in #16059:
MgpstrForSceneTextRecognitionMgpstrModelPLBartForConditionalGenerationPLBartModelPix2StructTextModelRagModelSamModelSwin2SRModelWho can review?
@Rocketknight1, please