Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLaVA-NeXT-Video: fix generation with cache #32527

Closed
wants to merge 2 commits into from
Closed

LLaVA-NeXT-Video: fix generation with cache #32527

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00099bb
fix llava-next-video generation
zucchini-nlp Aug 8, 2024
7c70acb
add tests
zucchini-nlp Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/models/llava_next_video/modeling_llava_next_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,7 @@ def forward(
inputs_embeds = self.get_input_embeddings()(input_ids)

# Merge text and images in prefill stage
if past_key_values is None:
if past_key_values is None or past_key_values.get_seq_length() == 0:
# First merge image tokens if there are any
if pixel_values is not None and pixel_values.size(0) > 0:
image_features = self._get_image_features(pixel_values, image_sizes)
Expand Down
Loading