Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPU support SDPA #35165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NPU support SDPA #35165

wants to merge 1 commit into from

Conversation

zheliuyu
Copy link

@zheliuyu zheliuyu commented Dec 9, 2024

What does this PR do?

add features: Ascend NPU supports SDPA.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

notes

Ascend NPU requires torch>=2.1.0 to use SDPA in Transformers.

@zheliuyu zheliuyu force-pushed the main branch 5 times, most recently from 2ed0a86 to 63c2f92 Compare December 13, 2024 07:56
@zheliuyu
Copy link
Author

@LysandreJik Hello, could you please help me review this code?

@zheliuyu zheliuyu changed the title Ascend NPU support SDPA NPU support SDPA Dec 14, 2024
@zheliuyu
Copy link
Author

@SunMarc Hi, this PR has been stuck for many days. Can you help me review it?
If there are any problems, please let me know. ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants