Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length-normalized DPO #2458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hugoabonizio
Copy link

What does this PR do?

This PR adds the length-normalized DPO used in Tulu-3 and introduced in the SimPO paper under dpo_norm loss type. This implementation and naming were inspired by the Open-Instruct implementation [1] [2].

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec
Copy link
Member

Hey, thanks for contributing!

Is it really a loss type? It seems to me that it can be combined with any loss type, no?

What about having a new arg in DPOConfig? maybe length_normalize?

Also, I'd add a test for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants