Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When readonly should not set stars to 0 #12

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

gonzalo-lorieto
Copy link
Contributor

No description provided.

@gonzalo-lorieto
Copy link
Contributor Author

For the ones having this issue, you can workaround it by doing this in the parent component:

    ...
    @ViewChild(NgxStarsComponent)
    starsComponent: NgxStarsComponent;
    ...
    ngAfterViewInit(): void {
        if (this.starsComponent.readonly) {
            this.starsComponent.onZeroStarClick = (): void => {};
        }
    }

Copy link
Owner

@hughjdavey hughjdavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for finding this and fixing it! I will bump the version number and get a release out to npm soon :)

@hughjdavey hughjdavey merged commit 0d78f65 into hughjdavey:master Nov 11, 2022
@hughjdavey
Copy link
Owner

Release 1.6.4 is on npm now containing this fix. Thanks again @gonzalo-lorieto

@gonzalo-lorieto gonzalo-lorieto deleted the patch-1 branch November 15, 2022 13:52
@gonzalo-lorieto
Copy link
Contributor Author

@hughjdavey can you bump v 1.5.1 with this fix?

@hughjdavey
Copy link
Owner

@gonzalo-lorieto Unfortunately I don't think npm allows editing or deleting published versions. Why do you want in 1.5.1? I guess I could make a 1.5.2?

@gonzalo-lorieto
Copy link
Contributor Author

@gonzalo-lorieto Unfortunately I don't think npm allows editing or deleting published versions. Why do you want in 1.5.1? I guess I could make a 1.5.2?

Exactly, create the 1.5.2 version with this fix. Latest version doesn't work for my project. Thanks!

@hughjdavey
Copy link
Owner

So what is the latest version that works for you? 1.5.1 was the release where I disabled the Ivy compiler, so if that works for you, then the latest release should too

@gonzalo-lorieto
Copy link
Contributor Author

@hughjdavey 1.5.1 works but 1.6.x doesn't

@hughjdavey
Copy link
Owner

hughjdavey commented Nov 21, 2022

Which 1.6.x releases have you tried? 1.6.3 fixed an issue with importing the library from other projects - so if you have only tried <1.6.3 that could be the reason? Can you let me know if >=1.6.3 works for you, and if not, the error/s you are getting and what version of Angular you are using? Thanks very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants