Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appdata: Improve appdata for AppStream 1.0 #174

Merged
merged 1 commit into from Jan 5, 2024
Merged

appdata: Improve appdata for AppStream 1.0 #174

merged 1 commit into from Jan 5, 2024

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2023

  • Add the <developer><name> tag
  • Mark the <developer_name> tag as deprecated
  • Mark the developer_name as untranslatable
  • Improve appstreamcli parameters
  • Activate meson tests on flatpak manifest

Appdata: Fix my mistake

"Icons and categories

If there’s a type="desktop-id" launchable, they get pulled from it. Most of the icon not found errors with the flathub builder can be traced down to the launchable value not matching the desktop file name.

Don’t set them in the AppData unless you want to override them (even though then it might be a better idea to patch the desktop file itself)."

More information: https://docs.flathub.org/docs/for-app-authors/appdata-guidelines/#icons-and-categories

- Add the `<developer><name>` tag
- Mark the `<developer_name>` tag as deprecated
- Mark the developer_name as untranslatable
- Improve appstreamcli parameters
- Activate meson tests on flatpak manifest

### Appdata: Fix my mistake

"Icons and categories

If there’s a type="desktop-id" launchable, they get pulled from it.
Most of the icon not found errors with the flathub builder can be
traced down to the launchable value not matching the desktop file name.

Don’t set them in the AppData unless you want to override them
(even though then it might be a better idea to patch the desktop file
itself)."

More information: https://docs.flathub.org/docs/for-app-authors/appdata-guidelines/#icons-and-categories
@camelCaseNick
Copy link
Contributor

camelCaseNick commented Dec 29, 2023

AppStream – Upstream Metadata says:

[…] The element should have a id property, containing a unique ID to identify the respective developer. […]

So, it seems the id should not identify the origin of the source, or where the <name> is used, but rather be a website controlled by the developer, such as hugolabe.github.io.

@ghost
Copy link
Author

ghost commented Dec 30, 2023

It's up to the developer; my viewpoint differs from yours.

The element is designed to represent the developers or project responsible
for development of the project described in the metadata.

The element should have a id property, containing a unique ID to identify the respective
developer. It is recommended to use a web URL, like gnome.org as ID to achieve a higher chance of uniqueness.

Every developer element must have a name tag as child, which contains a translatable name
for the respective developer. Values might be for example "The GNOME Foundation" or
"The KDE Community". Hyperlinks or emails must not be used in the name;
if you want to link to the developer's homepage, use the -tag instead.
The name tag is translatable.

  <developer id="example.org">
    <name>FooBar Team</name>
  </developer>

@hugolabe
Copy link
Owner

hugolabe commented Jan 5, 2024

Thanks @sabriunal !

Wouldn't it be better to remove the developer_name tag, since it is obsolete?

@ghost
Copy link
Author

ghost commented Jan 5, 2024

Flathub and GNOME Software do not yet support the new tags.

@hugolabe hugolabe merged commit 5a88213 into hugolabe:master Jan 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants