Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status code logging and use lazy % formatting in logging functions #70

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Apr 22, 2022

Follow on from #68.

@hugovk hugovk added the changelog: Fixed For any bug fixes label Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #70 (47541c7) into main (a8254b3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files           8        8           
  Lines         353      353           
=======================================
  Hits          338      338           
  Misses         15       15           
Flag Coverage Δ
GHA_Ubuntu 95.75% <100.00%> (ø)
GHA_Windows 95.75% <100.00%> (ø)
GHA_macOS 95.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/norwegianblue/__init__.py 98.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8254b3...47541c7. Read the comment docs.

@hugovk hugovk enabled auto-merge April 22, 2022 13:50
@hugovk hugovk merged commit 95b6214 into main Apr 22, 2022
@hugovk hugovk deleted the fix-logging branch April 22, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant