Add Origin to Vary header #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Often the response (mainly the `access-control-allow-origin` header) can vary depending on the value of the `Origin` HTTP header. We need to provide user-agents with this hint, so they don't use a cached response for requests with different Origin headers.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
rmccue
approved these changes
Jun 3, 2020
Well, moreover, we include it in the cache key by default, so it's our responsibility to set this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often the response (mainly the
access-control-allow-originheader) can vary depending on the value of theOriginHTTP header. We need to provide user-agents with this hint, so they don't use a cached response for requests with different Origin headers.