Optimize genlocks usage #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently many requests unnecesarily get no batcache serving or headers set due to over-generic genlocks. At the moment a single genlock goves a url path, like `/wp/v2/posts`, which means any requests to `/wp/v2/posts?per_page=1` will not get cached, or send cache headers while the first request to `/wp/v2/posts` is processing. I see no reason why genlocks and versions should not be tracked against the exact batcache cache key, rather than URL-only.
roborourke
requested changes
Mar 30, 2021
roborourke
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently many requests unnecesarily get no batcache serving or headers set due to over-generic genlocks. At the moment a single genlock goves a url path, like
/wp/v2/posts, which means any requests to/wp/v2/posts?per_page=1will not get cached, or send cache headers while the first request to/wp/v2/postsis processing.I see no reason why genlocks and versions should not be tracked against the exact batcache cache key, rather than URL-only.