Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for serving scripts over HTTPS #38

Merged
merged 2 commits into from
Oct 31, 2018

Conversation

Shelob9
Copy link
Contributor

@Shelob9 Shelob9 commented Sep 11, 2018

This totally tripped me up, dev server worked, but could not load scripts in my local WordPress site, which is using HTTPS. create-react-app has easy to set up, but poorly documented support for HTTPS.

facebook/create-react-app#552

I wanted to commit my solution so I will find it here in the future when I make the same mistake.

Copy link
Member

@rmccue rmccue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

How does the certificate warning work with the self-signed certificate? Will the browser present the certificate even when only from an external thing, or do you need to manually go to localhost:3000 to bring the dialog up?

@Shelob9
Copy link
Contributor Author

Shelob9 commented Sep 12, 2018

I loaded localhost:3000 in Chrome first. I got the untrusted cert warning. I don't know if that was a necessary step to make it work in WordPress or not.

@Shelob9
Copy link
Contributor Author

Shelob9 commented Sep 12, 2018

Today I restarted the dev server and didn't load the localhost. In WordPress I got a 404 for the bundle. Then I opened localhost in the browser and dismissed the cert warning. After that, WordPress was able to load the bundle from the dev server.

@rmccue Should I update the PR with this info?

@rmccue
Copy link
Member

rmccue commented Sep 13, 2018

@Shelob9 That'd be great, thanks!

@kadamwhite kadamwhite merged commit afb1c0f into humanmade:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants