Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing key, rename confusing #471

Merged
merged 3 commits into from
Oct 5, 2023
Merged

feat: add missing key, rename confusing #471

merged 3 commits into from
Oct 5, 2023

Conversation

Jezza34000
Copy link
Contributor

Translation files :

  • Renaming confusing "mop_mode" to "route" to match Roborock app's denomination (both in FR/EN)
  • Adding missing "Fast" key to translation in route.
  • Adding Low/Medium/High missing key for Mop intensity when using some robots
  • Adding "sound_volume" translation key for french

jalcaras and others added 3 commits September 12, 2023 13:57
feat(translation): English rename confusing mop_mode to route, add mi…
a91419c 
…ssing Fast key, add Mop intensity Low/Medium/High
feat(translation): French rename confusing mop_mode to parcours (rout…
1674503 
…e in english), add missing Fast key, add Mop intensity Low/Medium/High, add new key sound_volume to match french translation
@Jezza34000
Merge branch 'humbertogontijo:main' into main
ce247a7
Lash-L
Lash-L approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@Lash-L Lash-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@humbertogontijo humbertogontijo merged commit 7c35817 into humbertogontijo:main Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humbertogontijo humbertogontijo humbertogontijo approved these changes

@Lash-L Lash-L Lash-L approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jezza34000 @Lash-L @humbertogontijo