Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom state for charging and will continue #131

Closed
wants to merge 1 commit into from

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Oct 20, 2023

This way a user can tell if their vacuum is just charging or if it is charging and planning to continue cleaning

@humbertogontijo
Copy link
Owner

Shouldn't this be done on automations and not in the library itself?

@Lash-L
Copy link
Collaborator Author

Lash-L commented Oct 20, 2023

My thought was that this is generic enough of information that it should always be available to the user rather than the user having to specify it in an automation- and I'm surprised it is not a base state to begin with. But I'm open to not doing it.

It is kind of weird though since it takes a class that previously only specified data from the api directly and makes it semi-manual.

I'm open to going either way - was curious on your thoughts

@humbertogontijo
Copy link
Owner

How it goes in the app?

@Lash-L
Copy link
Collaborator Author

Lash-L commented Oct 20, 2023

How it goes in the app?

iirc - it says the device is charging and then the bottom part says 'stop' and 'dock' like it typically does when you can cancel a clean

@humbertogontijo
Copy link
Owner

I think it will be better not create sub statuses. Using in_cleaning as an entity might be the way to go

@Lash-L Lash-L closed this Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants