Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: house keeping, version bumping, doc fixes, doc improvements, v2 home data api #157

Merged
merged 9 commits into from
Dec 10, 2023

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Dec 8, 2023

Hoping docs will not fail to build now as well

humbertogontijo
humbertogontijo previously approved these changes Dec 8, 2023
Copy link
Owner

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Lash-L
Copy link
Collaborator Author

Lash-L commented Dec 8, 2023

@humbertogontijo There is a depreciation for read the docs that is going to take place in January.
https://blog.readthedocs.com/security-update-on-incoming-webhooks/

I think you can fix it by just going here and hitting resync webhook:
https://readthedocs.org/dashboard/python-roborock/integrations/238448/

But I don't have webhook permissions for this project, so I can't do it and I think you need to.

@Lash-L Lash-L changed the title feat: Random house keeping, version bumping, doc fixes, doc improvements feat: house keeping, version bumping, doc fixes, doc improvements, v2 home data api Dec 10, 2023
@Lash-L
Copy link
Collaborator Author

Lash-L commented Dec 10, 2023

This now includes v2 of home_data api @humbertogontijo

@humbertogontijo
Copy link
Owner

Copy link
Owner

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Nice job on home data v2 btw

@Lash-L Lash-L merged commit f3ca9b4 into humbertogontijo:main Dec 10, 2023
5 of 6 checks passed
@Lash-L
Copy link
Collaborator Author

Lash-L commented Dec 10, 2023

Approved.

Nice job on home data v2 btw

Thanks!

@Lash-L
Copy link
Collaborator Author

Lash-L commented Dec 10, 2023

https://readthedocs.org/dashboard/python-roborock/integrations/238448/ gave me a 404

Just login then go to python Roborock then admin then integrations let me know if that works @humbertogontijo

@humbertogontijo
Copy link
Owner

humbertogontijo commented Dec 10, 2023

Somehow I can't see admin button
image
I see you as a maintainer, maybe you need to add me?

@Lash-L
Copy link
Collaborator Author

Lash-L commented Dec 10, 2023

Ah seems like I only had maintainer rights for the docs. I have sent an invite to you - I would have figured it would have just given you the rights because you are the code owner here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants