-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: house keeping, version bumping, doc fixes, doc improvements, v2 home data api #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@humbertogontijo There is a depreciation for read the docs that is going to take place in January. I think you can fix it by just going here and hitting resync webhook: But I don't have webhook permissions for this project, so I can't do it and I think you need to. |
This now includes v2 of home_data api @humbertogontijo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Nice job on home data v2 btw
Thanks! |
Just login then go to python Roborock then admin then integrations let me know if that works @humbertogontijo |
Ah seems like I only had maintainer rights for the docs. I have sent an invite to you - I would have figured it would have just given you the rights because you are the code owner here |
Hoping docs will not fail to build now as well