Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add warning in web requests if it fails to decode #215

Merged
merged 1 commit into from
Jun 7, 2024
Merged

feat: add warning in web requests if it fails to decode #215

merged 1 commit into from
Jun 7, 2024

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Jun 7, 2024

No description provided.

humbertogontijo
humbertogontijo approved these changes Jun 7, 2024
View reviewed changes
Copy link
Owner

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lash-L Lash-L merged commit 6ae69e9 into main Jun 7, 2024
7 checks passed
@Lash-L
Copy link
Collaborator Author

Lash-L commented Jun 24, 2024

Using this to message you to ask @humbertogontijo -

I've been a bit overwhelmed with the core integration for Roborock and so I was going to look around asking for help. I was wondering if you wanted me to remove you from the codeowners on the core integration as I know that's never really been something that you signed up for and you get pinged for every new issue. And I figure I might have better luck getting more codeowners to sign up if it just shows one person working on it

What are your thoughts?

@humbertogontijo
Copy link
Owner

Hey @Lash-L !
Those messages don't bother me too much.
I wish I could help more, but unfortunately I cant.
With that said, I agree with you. Since I never actively helped in core integration, I think it would make more sense to be removed.
I hope you find some codeowners to help you with the integration

ricopinazo added a commit to ricopinazo/python-roborock that referenced this pull request Jun 28, 2024
@ricopinazo @Lash-L
@Ongion @PatrikTheDev @ethemcemozkan @user-08-151
Bring new changes (#1)
7f5cea5 
* fix: handle weird clean record response (humbertogontijo#206)

* 2.2.2

Automatically generated by python-semantic-release

* chore: Update documentation for reset_consumable (humbertogontijo#207)

Document parameter for API function reset_consumable

* chore: add load multi map parameter to docs(humbertogontijo#209)

* S8 maxv highest mop intensity setting (humbertogontijo#210)

* fix: s8 maxv has a wash and fill dock (humbertogontijo#213)

* 2.2.3

Automatically generated by python-semantic-release

* S8MaxVUltra is missing some code mappings (humbertogontijo#214)

* fix: add missing smart mode for s8 maxv dock

* fix: add missing modes for s8 maxv ultra

* fix: add missing modes for s8 maxv ultra

* feat: add warning in web requests if it fails to decode (humbertogontijo#215)

* 2.3.0

Automatically generated by python-semantic-release

* feat: add some missing codes and make warnings only message once (humbertogontijo#218)

* 2.4.0

Automatically generated by python-semantic-release

* feat: add some typing (humbertogontijo#219)

* 2.5.0

Automatically generated by python-semantic-release

---------

Co-authored-by: Luke Lashley <conway220@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Benjamin Paul [MSFT] <benjamin.ian.paul@gmail.com>
Co-authored-by: PatrikTheDev <svob.pata@gmail.com>
Co-authored-by: Ethem Cem Özkan <ethemcem.ozkan@gmail.com>
Co-authored-by: Willy <168727804+user-08-151@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humbertogontijo humbertogontijo humbertogontijo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lash-L @humbertogontijo